ryan77627/guix
1
0
Fork 0
mirror of https://git.in.rschanz.org/ryan77627/guix.git synced 2024-12-25 05:48:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

lint: Check for trailing whitespace in synopsis.

Browse source 
* guix/lint.scm (check-synopsis-style): Check for trailing whitespace.
* tests/lint.scm ("synopsis: contains trailing whitespace"): New test.

Signed-off-by: Ludovic Courtès <ludo@gnu.org>
This commit is contained in:
Xinglu Chen 2021-05-30 22:30:31 +02:00 committed by Ludovic Courtès
parent 9178566954
commit 04afb76958
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5
2 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
guix/lint.scm
View file

@ -478,13 +478,23 @@ (define (check-texinfo-markup synopsis)
(G_ "Texinfo markup in synopsis is invalid") (G_ "Texinfo markup in synopsis is invalid")
#:field 'synopsis))))) #:field 'synopsis)))))
(define (check-no-trailing-whitespace synopsis)
"Check that SYNOPSIS doesn't have trailing whitespace."
(if (string-suffix? " " synopsis)
(list
(make-warning package
(G_ "synopsis contains trailing whitespace")
#:field 'synopsis))
'()))
(define checks (define checks
(list check-proper-start (list check-proper-start
check-final-period check-final-period
check-start-article check-start-article
check-start-with-package-name check-start-with-package-name
check-synopsis-length check-synopsis-length
check-texinfo-markup)) check-texinfo-markup
check-no-trailing-whitespace))
(match (package-synopsis package) (match (package-synopsis package)
("" (""

7
tests/lint.scm
View file

@ -271,6 +271,13 @@ (define (warning-contains? str warnings)
(description "Imagine this is Taylor UUCP.")))) (description "Imagine this is Taylor UUCP."))))
(check-synopsis-style pkg))) (check-synopsis-style pkg)))
(test-equal "synopsis: contains trailing whitespace"
"synopsis contains trailing whitespace"
(single-lint-warning-message
(let ((pkg (dummy-package "x"
(synopsis "Whitespace "))))
(check-synopsis-style pkg))))
(test-equal "name: use underscore in package name" (test-equal "name: use underscore in package name"
"name should use hyphens instead of underscores" "name should use hyphens instead of underscores"
(single-lint-warning-message (single-lint-warning-message