gnu: dovecot-trees: Fix build with dovecot 2.3.

* gnu/packages/mail.scm (dovecot-trees)[source]: Add patch.
* gnu/packages/patches/dovecot-trees-support-dovecot-2.3.patch: New
file.
* gnu/local.mk (dist_patch_DATA): Add it.
This commit is contained in:
Tobias Geerinckx-Rice 2018-06-25 00:37:53 +02:00
parent fecbbc2820
commit 0e66f4a12f
No known key found for this signature in database
GPG key ID: 0DB0FF884F556D79
3 changed files with 64 additions and 1 deletions

View file

@ -639,6 +639,7 @@ dist_patch_DATA = \
%D%/packages/patches/docbook-xsl-nonrecursive-string-subst.patch \ %D%/packages/patches/docbook-xsl-nonrecursive-string-subst.patch \
%D%/packages/patches/doc++-include-directives.patch \ %D%/packages/patches/doc++-include-directives.patch \
%D%/packages/patches/doc++-segfault-fix.patch \ %D%/packages/patches/doc++-segfault-fix.patch \
%D%/packages/patches/dovecot-trees-support-dovecot-2.3.patch \
%D%/packages/patches/doxygen-gcc-ice.patch \ %D%/packages/patches/doxygen-gcc-ice.patch \
%D%/packages/patches/doxygen-test.patch \ %D%/packages/patches/doxygen-test.patch \
%D%/packages/patches/dvd+rw-tools-add-include.patch \ %D%/packages/patches/dvd+rw-tools-add-include.patch \

View file

@ -1273,7 +1273,9 @@ (define-public dovecot-trees
(file-name (string-append name "-" version ".tar.gz")) (file-name (string-append name "-" version ".tar.gz"))
(sha256 (sha256
(base32 (base32
"0rkk10b1bsjz979sc864vpgcdchy7yxwmyv4ik50lar1h6awdnrf")))) "0rkk10b1bsjz979sc864vpgcdchy7yxwmyv4ik50lar1h6awdnrf"))
(patches
(search-patches "dovecot-trees-support-dovecot-2.3.patch"))))
(build-system gnu-build-system) (build-system gnu-build-system)
(native-inputs (native-inputs
`(("automake" ,automake) `(("automake" ,automake)

View file

@ -0,0 +1,60 @@
From: Tobias Geerinckx-Rice <me@tobias.gr>
Date: Mon, 25 Jun 2018 00:34:52 +0200
Subject: dovecot-trees: Fix build with dovecot 2.3.
The following patch was taken verbatim from the upstream repository[0]
and will be included in the next release.
[0]: https://0xacab.org/riseuplabs/trees/commit/e136c32a044701d68b0235b8405357c5fca62a11
---
From e136c32a044701d68b0235b8405357c5fca62a11 Mon Sep 17 00:00:00 2001
From: David Goulet <dgoulet@ev0ke.net>
Date: Tue, 10 Apr 2018 13:48:01 -0400
Subject: [PATCH] Support dovecot 2.3
Untested but it builds now properly. Thanks to "smorks" for the report!
Fixes #16
Signed-off-by: David Goulet <dgoulet@ev0ke.net>
---
src/trees-istream.c | 4 ++++
src/trees-ostream.c | 7 +++++++
2 files changed, 11 insertions(+)
diff --git a/src/trees-istream.c b/src/trees-istream.c
index b08ff16..e94be7d 100644
--- a/src/trees-istream.c
+++ b/src/trees-istream.c
@@ -431,5 +431,9 @@ trees_istream_create(struct istream *input,
sstream->out_byte_count = 0;
#endif
+#if DOVECOT_PREREQ(2, 3)
+ return i_stream_create(&sstream->istream, input, i_stream_get_fd(input), 0);
+#else
return i_stream_create(&sstream->istream, input, i_stream_get_fd(input));
+#endif /* DOVECOT_PREREQ */
}
diff --git a/src/trees-ostream.c b/src/trees-ostream.c
index 1b25a91..0cb7867 100644
--- a/src/trees-ostream.c
+++ b/src/trees-ostream.c
@@ -174,7 +174,14 @@ trees_ostream_sendv(struct ostream_private *stream,
static int
trees_ostream_flush(struct ostream_private *stream)
{
+ /* This is pretty ugly but unfortunately between 2.2 and 2.3, Dovecot changed
+ * the expected value to be non zero in 2.3+ . */
+#if DOVECOT_PREREQ(2, 3)
+ ssize_t result = 1;
+#else
ssize_t result = 0;
+#endif /* DOVECOT_PREREQ */
+
struct trees_ostream *sstream = (struct trees_ostream *) stream;
if (sstream->flushed) {
--
2.17.1