From 3cd509bf66dc322d89dfcf8e1608b53b859206a0 Mon Sep 17 00:00:00 2001 From: Maxime Devos Date: Thu, 8 Jul 2021 17:07:42 +0200 Subject: [PATCH] gnu: python-pymediainfo: Respect "--without-tests". * gnu/packages/python-xyz.scm (python-pymediainfo)[arguments]<#:phases>{check}: Respect #:tests?. Don't bother returning #t as it isn't required anymore. Signed-off-by: Mathieu Othacehe --- gnu/packages/python-xyz.scm | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index cca4d9a830..5a44043635 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -103,6 +103,7 @@ ;;; Copyright © 2021 Raghav Gururajan ;;; Copyright © 2021 jgart ;;; Copyright © 2021 Danial Behzadi +;;; Copyright © 2021 Maxime Devos ;;; ;;; This file is part of GNU Guix. ;;; @@ -857,14 +858,14 @@ (define-public python-pymediainfo "/lib/libmediainfo.so.0"))) #t)) (replace 'check - (lambda _ - ;; Extend PYTHONPATH so the built package will be found. - (setenv "PYTHONPATH" - (string-append (getcwd) "/build/lib:" - (getenv "PYTHONPATH"))) - ;; Skip the only failing test "test_parse_url" - (invoke "pytest" "-vv" "-k" "not test_parse_url") - #t))))) + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + ;; Extend PYTHONPATH so the built package will be found. + (setenv "PYTHONPATH" + (string-append (getcwd) "/build/lib:" + (getenv "PYTHONPATH"))) + ;; Skip the only failing test "test_parse_url" + (invoke "pytest" "-vv" "-k" "not test_parse_url"))))))) (home-page "https://github.com/sbraz/pymediainfo") (synopsis