From 4f51a4ac278d5001e0afdba3c5425e0bd6673505 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Wed, 21 Jul 2021 17:30:20 -0400 Subject: [PATCH] utils: Do not request block buffering in pretty-print-table. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Re-testing 'guix package -A' using the default line buffering set in (guix ui), there doesn't seem to be a performance gain to use block buffering, so remove this extraneous side effect. * guix/utils.scm (pretty-print-table): Do not set buffering mode to block. Reported-by: Ludovic Courtès --- guix/utils.scm | 1 - 1 file changed, 1 deletion(-) diff --git a/guix/utils.scm b/guix/utils.scm index 2c56c8b2e0..2920fa7684 100644 --- a/guix/utils.scm +++ b/guix/utils.scm @@ -963,7 +963,6 @@ (define* (pretty-print-table rows #:key (max-column-width 20)) (map (cut min <> max-column-width) column-widths))) (fmt (string-append (string-join column-formats "\t") "\t~a"))) - (setvbuf (current-output-port) 'block) ;for better performance (for-each (cut format #t "~?~%" fmt <>) rows))) ;;; Local Variables: