ryan77627/guix
1
0
Fork 0
mirror of https://git.in.rschanz.org/ryan77627/guix.git synced 2024-12-24 21:38:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

lint: Rename 'check-patches' to 'check-patch-file-names'.

Browse source 
* guix/scripts/lint.scm (check-patches): Rename to...
  (check-patch-file-names): ... this.  Rename 'filename' to 'file'.
  (%checkers): Adjust accordingly.
* tests/lint.scm ("patches: file names"): Likewise.
This commit is contained in:
Ludovic Courtès 2015-04-10 10:08:49 +02:00
parent a55e2b221c
commit 56b1b74c90
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
guix/scripts/lint.scm
View file

@ -45,7 +45,7 @@ (define-module (guix scripts lint)
#:export (guix-lint
check-description-style
check-inputs-should-be-native
check-patches
check-patch-file-names
check-synopsis-style
check-home-page
check-source))
@ -348,7 +348,7 @@ (define (check-home-page package)
(package-home-page package))
'home-page)))))
(define (check-patches package)
(define (check-patch-file-names package)
;; Emit a warning if the patches requires by PACKAGE are badly named.
(let ((patches (and=> (package-source package) origin-patches))
(name (package-name package))
@ -356,9 +356,9 @@ (define (check-patches package)
(when (and patches
(any (match-lambda
((? string? patch)
(let ((filename (basename patch)))
(not (or (eq? (string-contains filename name) 0)
(eq? (string-contains filename full-name)
(let ((file (basename patch)))
(not (or (eq? (string-contains file name) 0)
(eq? (string-contains file full-name)
0)))))
(_
;; This must be an <origin> or something like that.
@ -367,7 +367,7 @@ (define (check-patches package)
(emit-warning package
(_ "file names of patches should start with \
the package name")
'patches))))
'patch-file-names))))
(define (escape-quotes str)
"Replace any quote character in STR by an escaped quote character."
@ -455,9 +455,9 @@ (define %checkers
(description "Identify inputs that should be native inputs")
(check check-inputs-should-be-native))
(lint-checker
(name 'patch-filenames)
(name 'patch-file-names)
(description "Validate file names of patches")
(check check-patches))
(check check-patch-file-names))
(lint-checker
(name 'home-page)
(description "Validate home-page URLs")

2
tests/lint.scm
View file

@ -301,7 +301,7 @@ (define-syntax-rule (with-warnings body ...)
(uri "someurl")
(sha256 "somesha")
(patches (list "/path/to/y.patch")))))))
(check-patches pkg)))
(check-patch-file-names pkg)))
"file names of patches should start with the package name")))
(test-assert "home-page: wrong home-page"