union: Delete duplicates when passed the same input several times.

* guix/build/union.scm (union-build): Prepend "." to the result of
  `union-tree', to match the expectations of `delete-duplicate-leaves'.
  Don't do mkdir when SUBDIR is ".".
* tests/union.scm ("union-build"): Keep duplicates in %BOOTSTRAP-INPUTS.
This commit is contained in:
Ludovic Courtès 2013-02-06 22:51:24 +01:00
parent 44ce77ff52
commit 6211223021
2 changed files with 10 additions and 7 deletions

View file

@ -150,8 +150,9 @@ (define (resolve-collision leaves)
(mkdir output) (mkdir output)
(let loop ((tree (delete-duplicate-leaves (let loop ((tree (delete-duplicate-leaves
(tree-union (append-map (compose tree-leaves file-tree) (cons "."
directories)) (tree-union (append-map (compose tree-leaves file-tree)
directories)))
leaf=? leaf=?
resolve-collision)) resolve-collision))
(dir '())) (dir '()))
@ -165,8 +166,9 @@ (define (resolve-collision leaves)
(symlink tree target))) (symlink tree target)))
(((? string? subdir) leaves ...) (((? string? subdir) leaves ...)
;; A sub-directory: create it in OUTPUT, and iterate over LEAVES. ;; A sub-directory: create it in OUTPUT, and iterate over LEAVES.
(let ((dir (string-join dir "/"))) (unless (string=? subdir ".")
(mkdir (string-append output "/" dir "/" subdir))) (let ((dir (string-join dir "/")))
(mkdir (string-append output "/" dir "/" subdir))))
(for-each (cute loop <> `(,@dir ,subdir)) (for-each (cute loop <> `(,@dir ,subdir))
leaves)) leaves))
((leaves ...) ((leaves ...)

View file

@ -94,9 +94,10 @@ (define %store
(let* ((inputs (map (match-lambda (let* ((inputs (map (match-lambda
((name package) ((name package)
`(,name ,(package-derivation %store package)))) `(,name ,(package-derivation %store package))))
(delete-duplicates %bootstrap-inputs
(lambda (i1 i2) ;; Purposefully leave duplicate entries.
(eq? (second i1) (second i2)))))) (append %bootstrap-inputs
(take %bootstrap-inputs 3))))
(builder `(begin (builder `(begin
(use-modules (guix build union)) (use-modules (guix build union))
(union-build (assoc-ref %outputs "out") (union-build (assoc-ref %outputs "out")