ryan77627/guix
1
0
Fork 0
mirror of https://git.in.rschanz.org/ryan77627/guix.git synced 2024-11-07 07:26:13 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

snippets: Harden for review activity.

Browse source 
When reviewing patches, whose commit logs don't follow the structure outlined
in “Submitting Patches”, a reviewer might be tempted to use snippets to
rewrite them.  This makes it so that their attempt, while not immediately
succeeding, isn't completely thwarted.

* etc/snippets/tempel/text-mode (add\ , remove\ , rename\ , update\ )
(addcl\ , https\ ): Use an empty "p" field if (car (magit-staged-files))
fails.
This commit is contained in:
Liliana Marie Prikler 2022-10-22 14:05:44 +02:00
parent 28270e1e03
commit 85aff4de30
No known key found for this signature in database
GPG key ID: 442A84B8C70E2F87
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
etc/snippets/tempel/text-mode
View file

@ -12,7 +12,8 @@ text-mode :when (and (fboundp 'git-commit-mode) (git-commit-mode))
(match-string-no-properties 1)))
var)
"." n n
"* " (car (magit-staged-files)) " (" (s var ) "): New variable.")
"* " (p (or (car (magit-staged-files)) ""))
" (" (s var ) "): New variable.")
(remove\ "gnu: Remove "
(p (with-temp-buffer
@ -24,7 +25,8 @@ text-mode :when (and (fboundp 'git-commit-mode) (git-commit-mode))
(match-string-no-properties 1)))
var)
"." n n
"* " (car (magit-staged-files)) " (" (s var) "): Delete variable.")
"* " (p (or (car (magit-staged-files)) ""))
" (" (s var) "): Delete variable.")
(rename\ "gnu: "
(p (with-temp-buffer
@ -43,7 +45,7 @@ text-mode :when (and (fboundp 'git-commit-mode) (git-commit-mode))
(thing-at-point 'sexp 'no-properties)))
new-var)
"." n n
"* " (car (magit-staged-files)) " (" (s prev-var) "): "
"* " (p (or (car (magit-staged-files)) "")) " (" (s prev-var) "): "
"Define in terms of" n
"'deprecated-package'." n
"(" (s new-var) "): New variable, formerly known as \""
@ -74,7 +76,7 @@ text-mode :when (and (fboundp 'git-commit-mode) (git-commit-mode))
(buffer-substring-no-properties (point) (- end 2))))))
version)
"." n n
"* " (car (magit-staged-files)) " (" (s var) "): "
"* " (p (or (car (magit-staged-files)) "")) " (" (s var) "): "
"Update to " (s version) "." n
(mapconcat (lambda (file) (concat "* " file))
(cdr (magit-staged-files))
@ -92,7 +94,7 @@ text-mode :when (and (fboundp 'git-commit-mode) (git-commit-mode))
(thing-at-point 'sexp 'no-properties)))))
var)
"." n n
"* " (car (magit-staged-files))
"* " (p (or (car (magit-staged-files)) ""))
" (cl-" (s var)
", ecl-" (s var)
", sbcl-" (s var) "): New variables.")
@ -107,7 +109,8 @@ text-mode :when (and (fboundp 'git-commit-mode) (git-commit-mode))
(match-string-no-properties 1)))
var)
": Use HTTPS home page." n n
"* " (car (magit-staged-files)) " (" (s var) ")[home-page]: Use HTTPS."
"* " (p (or (car (magit-staged-files)) ""))
" (" (s var) ")[home-page]: Use HTTPS."
n
(mapconcat (lambda (file) (concat "* " file))
(cdr (magit-staged-files))