ryan77627/guix
1
0
Fork 0
mirror of https://git.in.rschanz.org/ryan77627/guix.git synced 2024-12-25 13:58:15 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

build: qt-utils: Fix another regression.

Browse source 
This fixes another regression introduced with
1f466ed6be, which affected the packages bitmask,
hime, hime, nimf and vorta.

The fix is to provide a default qt-major-version when #:qtbase is missing,
such as when borrowing the qt-wrap phase in a package not using the Qt build
system.

* guix/build/qt-utils.scm (wrap-all-qt-programs)[qt-major-version]: Fall-back
to %default-qt-major-version when #:qtbase is #f.

Reported-by: John Kehayias <john.kehayias@protonmail.com> and others.
This commit is contained in:
Maxim Cournoyer 2022-08-04 11:47:03 -04:00
parent e920ba0b1d
commit a956c7df87
No known key found for this signature in database
GPG key ID: 1260E46482E63562
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
guix/build/qt-utils.scm
View file

@ -144,9 +144,13 @@ (define* (wrap-all-qt-programs #:key inputs outputs
to contain any Qt binaries, and where wrapping would gratuitously
add a dependency of that output on Qt."
(define qt-major-version
(let ((_ version (package-name->name+version
(strip-store-file-name qtbase))))
(first (string-split version #\.))))
(if qtbase
(let ((_ version (package-name->name+version
(strip-store-file-name qtbase))))
(first (string-split version #\.)))
;; Provide a fall-back for build systems not having a #:qtbase
;; argument.
%default-qt-major-version))
(define (find-files-to-wrap output-dir)
(append-map