services: nfs: Allow idmap-service-type to be extended.

* gnu/services/nfs.scm (idmap-service-type): Rewrite using SERVICE-TYPE to add
ability to extend the service.
This commit is contained in:
Ricardo Wurmus 2020-01-03 18:13:38 +01:00
parent 5d4ba49891
commit af32ea3583
No known key found for this signature in database
GPG key ID: 197A5888235FACAC

View file

@ -170,37 +170,48 @@ (define-record-type* <idmap-configuration>
(default nfs-utils))) (default nfs-utils)))
(define idmap-service-type (define idmap-service-type
(shepherd-service-type (let ((proc
'idmap (lambda (config)
(lambda (config)
(define nfs-utils (define nfs-utils
(idmap-configuration-nfs-utils config)) (idmap-configuration-nfs-utils config))
(define pipefs-directory (define pipefs-directory
(idmap-configuration-pipefs-directory config)) (idmap-configuration-pipefs-directory config))
(define domain (idmap-configuration-domain config)) (define domain (idmap-configuration-domain config))
(define (idmap-config-file config) (define (idmap-config-file config)
(plain-file "idmapd.conf" (plain-file "idmapd.conf"
(string-append (string-append
"\n[General]\n" "\n[General]\n"
(if domain (if domain
(format #f "Domain = ~a\n" domain)) (format #f "Domain = ~a\n" domain)
"\n[Mapping]\n" "")
"Nobody-User = nobody\n" "\n[Mapping]\n"
"Nobody-Group = nogroup\n"))) "Nobody-User = nobody\n"
"Nobody-Group = nogroup\n")))
(define idmap-command (define idmap-command
#~(list (string-append #$nfs-utils "/sbin/rpc.idmapd") "-f" #~(list (string-append #$nfs-utils "/sbin/rpc.idmapd") "-f"
"-p" #$pipefs-directory "-p" #$pipefs-directory
"-c" #$(idmap-config-file config))) ;; TODO: this is deprecated
"-c" #$(idmap-config-file config)))
(shepherd-service
(documentation "Start the RPC IDMAP daemon.")
(requirement '(rpcbind-daemon rpc-pipefs))
(provision '(idmap-daemon))
(start #~(make-forkexec-constructor #$idmap-command))
(stop #~(make-kill-destructor))))))
(shepherd-service
(documentation "Start the RPC IDMAP daemon.")
(requirement '(rpcbind-daemon rpc-pipefs))
(provision '(idmap-daemon))
(start #~(make-forkexec-constructor #$idmap-command))
(stop #~(make-kill-destructor))))))
(service-type
(name 'idmap)
(extensions
(list (service-extension shepherd-root-service-type
(compose list proc))))
;; We use the extensions feature to allow other services to automatically
;; configure and start this service. Only one value can be provided. We
;; override it with the value returned by the extending service.
(compose identity)
(extend (lambda (config values) (first values)))
(default-value (idmap-configuration)))))