ryan77627/guix
1
0
Fork 0
mirror of https://git.in.rschanz.org/ryan77627/guix.git synced 2024-12-24 21:38:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

gnu: go@1.12: Skip flaky GC test.

Browse source 
Fixes <https://bugs.gnu.org/37425>.

* gnu/packages/patches/go-skip-gc-test.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/golang.scm (go-1.12)[source]: Use it.
This commit is contained in:
Ludovic Courtès 2019-09-16 23:45:36 +02:00
parent 0b2ea78173
commit b938892551
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5
3 changed files with 22 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
gnu/local.mk
View file

@ -911,6 +911,7 @@ dist_patch_DATA = \
%D%/packages/patches/gobject-introspection-absolute-shlib-path.patch \
%D%/packages/patches/gobject-introspection-cc.patch \
%D%/packages/patches/gobject-introspection-girepository.patch \
%D%/packages/patches/go-skip-gc-test.patch \
%D%/packages/patches/gpm-glibc-2.26.patch \
%D%/packages/patches/gpsbabel-minizip.patch \
%D%/packages/patches/gpsbabel-qstring.patch \

6
gnu/packages/golang.scm
View file

@ -2,7 +2,7 @@
;;; Copyright © 2016, 2017, 2018, 2019 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
;;; Copyright © 2016 Andy Wingo <wingo@igalia.com>
;;; Copyright © 2016 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2016, 2019 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2016, 2017 Petter <petter@mykolab.ch>
;;; Copyright © 2016, 2017, 2019 Leo Famulari <leo@famulari.name>
;;; Copyright © 2017 Sergei Trofimovich <slyfox@inbox.ru>
@ -41,6 +41,7 @@ (define-module (gnu packages golang)
#:use-module (guix build-system gnu)
#:use-module (guix build-system trivial)
#:use-module (guix build-system go)
#:use-module (gnu packages)
#:use-module (gnu packages admin)
#:use-module (gnu packages gcc)
#:use-module (gnu packages base)
@ -408,7 +409,8 @@ (define-public go-1.12
name version ".src.tar.gz"))
(sha256
(base32
"04rvwj69gmw3bz8pw5pf10r21ar0pgpnswp15nkddf04dxyl9s4m"))))
"04rvwj69gmw3bz8pw5pf10r21ar0pgpnswp15nkddf04dxyl9s4m"))
(patches (search-patches "go-skip-gc-test.patch"))))
(arguments
(substitute-keyword-arguments (package-arguments go-1.4)
((#:phases phases)

17
gnu/packages/patches/go-skip-gc-test.patch Normal file
View file

@ -0,0 +1,17 @@
Skip a GC test known to be flaky:
https://issues.guix.gnu.org/issue/37425
https://github.com/golang/go/issues/27636
--- go/src/runtime/gc_test.go 2019-09-16 23:10:18.200680387 +0200
+++ go/src/runtime/gc_test.go 2019-09-16 23:11:50.324360646 +0200
@@ -27,6 +27,9 @@ func TestGcSys(t *testing.T) {
if runtime.GOOS == "linux" && runtime.GOARCH == "arm64" {
t.Skip("skipping test; GOOS=linux GOARCH=arm64 https://github.com/golang/go/issues/27636")
}
+ if runtime.GOOS == "linux" {
+ t.Skip("skipping test; GOOS=linux https://issues.guix.gnu.org/issue/37425")
+ }
got := runTestProg(t, "testprog", "GCSys")
want := "OK\n"
if got != want {