ryan77627/guix
1
0
Fork 0
mirror of https://git.in.rschanz.org/ryan77627/guix.git synced 2024-12-24 21:38:07 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

gnu: GSL: Disable failing tests on i686-linux and aarch64-linux.

Browse source 
This follows up commit 7ad3c81240, which enabled
tests that were previously disabled on i686, and takes into account new tests
with similar issues.  While at it, selectively disable tests on aarch64
instead of disabling all tests.

* gnu/packages/maths.scm (gsl)[arguments]: On i686 and aarch64, add #:phases.
This commit is contained in:
Marius Bakke 2020-04-03 15:53:10 +02:00
parent 3cff86db8a
commit c745b6f62c
No known key found for this signature in database
GPG key ID: A2A06DF2A33A54FA
1 changed files with 30 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
gnu/packages/maths.scm
View file

@ -26,7 +26,7 @@
;;; Copyright © 2018 Joshua Sierles, Nextjournal <joshua@nextjournal.com>
;;; Copyright © 2018 Nadya Voronova <voronovank@gmail.com>
;;; Copyright © 2018 Adam Massmann <massmannak@gmail.com>
;;; Copyright © 2018 Marius Bakke <mbakke@fastmail.com>
;;; Copyright © 2018, 2020 Marius Bakke <mbakke@fastmail.com>
;;; Copyright © 2018 Eric Brown <brown@fastmail.com>
;;; Copyright © 2018 Julien Lepiller <julien@lepiller.eu>
;;; Copyright © 2018 Amin Bandali <bandali@gnu.org>
@ -388,12 +388,35 @@ (define-public gsl
"1a460zj9xmbgvcymkdhqh313c4l29mn9cffbi5vf33x3qygk70mp"))))
(build-system gnu-build-system)
(arguments
`(;; Currently there are numerous tests that fail on "exotic"
;; architectures such as aarch64 and ppc64le.
,@(if (string-prefix? "aarch64-linux"
(or (%current-target-system) (%current-system)))
'(#:tests? #f)
'())))
(let ((system (%current-system)))
(cond
((string-prefix? "aarch64" system)
;; Some sparse matrix tests are failing on AArch64:
;; https://lists.gnu.org/archive/html/bug-gsl/2020-04/msg00001.html
'(#:phases (modify-phases %standard-phases
(add-before 'check 'disable-failing-tests
(lambda _
(substitute* "spmatrix/test.c"
((".*test_complex.*") "\n"))
#t)))))
((string-prefix? "i686" (%current-system))
;; There are rounding issues with these tests on i686:
;; https://lists.gnu.org/archive/html/bug-gsl/2016-10/msg00000.html
;; https://lists.gnu.org/archive/html/bug-gsl/2020-04/msg00000.html
'(#:phases (modify-phases %standard-phases
(add-before 'check 'disable-failing-tests
(lambda _
(substitute* "linalg/test.c"
((".*gsl_test\\(test_LU_decomp.*") "\n")
((".*gsl_test\\(test_LUc_decomp.*") "\n")
((".*gsl_test\\(test_cholesky_decomp.*") "\n")
((".*gsl_test\\(test_COD_lssolve2.*") "\n"))
(substitute* "spmatrix/test.c"
((".*test_all.*") "\n")
((".*test_float.*") "\n")
((".*test_complex.*") "\n"))
#t)))))
(else '()))))
(home-page "https://www.gnu.org/software/gsl/")
(synopsis "Numerical library for C and C++")
(description