ryan77627/guix
1
0
Fork 0
mirror of https://git.in.rschanz.org/ryan77627/guix.git synced 2025-01-12 14:16:55 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

file-systems: Open files with O_CLOEXEC.

Browse source 
Since this code is run from PID 1, this ensures file descriptors to
sensitive files and devices are not accidentally leaked to
sub-processes.

* gnu/build/file-systems.scm (call-with-input-file): New procedure.
(mount-file-system): Use 'close-fdes' + 'open-fdes'.
This commit is contained in:
Ludovic Courtès 2022-09-08 14:30:19 +02:00
parent 8f53630f2f
commit e05f7c55d7
No known key found for this signature in database
GPG key ID: 090B11993D9AEBB5
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
gnu/build/file-systems.scm
View file

@ -98,6 +98,18 @@ (define (system*/tty program . args)
system*/console) system*/console)
program args)) program args))
(define (call-with-input-file file proc)
"Like 'call-with-input-file', but pass O_CLOEXEC."
(let ((port #f))
(dynamic-wind
(lambda ()
(set! port (open file (logior O_RDONLY O_CLOEXEC))))
(lambda ()
(proc port))
(lambda ()
(close-port port)
(set! port #f)))))
(define (bind-mount source target) (define (bind-mount source target)
"Bind-mount SOURCE at TARGET." "Bind-mount SOURCE at TARGET."
(mount source target "" MS_BIND)) (mount source target "" MS_BIND))
@ -1183,7 +1195,8 @@ (define (mount-nfs source mount-point type flags options)
(not (file-is-directory? source))) (not (file-is-directory? source)))
(unless (file-exists? target) (unless (file-exists? target)
(mkdir-p (dirname target)) (mkdir-p (dirname target))
(call-with-output-file target (const #t))) (close-fdes
(open-fdes target (logior O_WRONLY O_CREAT O_CLOEXEC))))
(mkdir-p target)) (mkdir-p target))
(cond (cond