guix/guix
Ludovic Courtès 43c36c5c9f
ui: 'display-hint' quotes extra arguments for Texinfo.
Fixes <https://issues.guix.gnu.org/61201>.

Previously, common practice was to splice arbitrary strings (user names,
file names, etc.) into Texinfo snippets passed to 'display-hint'.  This
is unsafe in the general case because at signs and braces need to be
escaped to produced valid Texinfo.  This commit addresses that.

* guix/ui.scm (texinfo-quote): New procedure.
(display-hint): When ARGUMENTS is non-empty, pass it to 'texinfo-quote'
and call 'format'.
(report-unbound-variable-error, check-module-matches-file)
(display-collision-resolution-hint, run-guix-command): Remove explicit
'format' call; pass 'format' arguments as extra arguments to 'display-hint'.
* gnu/services/monitoring.scm (zabbix-front-end-config): Likewise.
* guix/scripts.scm (warn-about-disk-space): Likewise.
* guix/scripts/build.scm (%standard-cross-build-options)
(%standard-native-build-options): Likewise.
* guix/scripts/describe.scm (display-checkout-info): Likewise.
* guix/scripts/environment.scm (suggest-command-name): Likewise.
* guix/scripts/home.scm (process-command): Likewise.
* guix/scripts/home/edit.scm (service-type-not-found): Likewise.
* guix/scripts/import.scm (guix-import): Likewise.
* guix/scripts/package.scm (display-search-path-hint): Likewise.
* guix/scripts/pull.scm (build-and-install): Likewise.
* guix/scripts/shell.scm (auto-detect-manifest): Likewise.
* guix/scripts/system.scm (check-file-system-availability): Likewise.
(guix-system): Likewise.
* guix/scripts/system/edit.scm (service-type-not-found): Likewise.
* guix/status.scm (print-build-event): Likewise.
2023-02-27 23:40:43 +01:00
..
build build: haskell-build-system: Build static executables by default. 2023-02-26 10:26:16 +01:00
build-system build-system: haskell: Drop default "static" output. 2023-02-26 10:26:15 +01:00
import import: haskell: Add new internal library for GHC 9.2. 2023-02-26 10:20:14 +01:00
platforms platforms: x86: Rename Hurd hurd to i586-gnu. 2022-09-24 14:49:07 +02:00
scripts ui: 'display-hint' quotes extra arguments for Texinfo. 2023-02-27 23:40:43 +01:00
store deduplicate: Use 'sendfile' only with file ports. 2022-12-10 18:13:39 +01:00
tests
android-repo-download.scm
avahi.scm
base16.scm
base32.scm
base64.scm
build-system.scm
bzr-download.scm
cache.scm
channels.scm status: Print a hint when a 'package-cache' hook fails to build. 2023-02-11 00:09:40 +01:00
ci.scm ci: Add 'start-time' and 'stop-time' to <build> records. 2022-10-20 23:07:37 +02:00
colors.scm
combinators.scm
config.scm.in
cpio.scm cpio: Properly handle Unicode characters in file names. 2023-02-25 14:50:33 -05:00
cpu.scm
cve.scm
cvs-download.scm
d3.v3.js
deprecation.scm
derivations.scm derivations: 'read-derivation' correctly handles case with empty hash. 2023-01-09 17:40:53 +01:00
describe.scm
diagnostics.scm
discovery.scm
docker.scm
download.scm download: Add bordeaux.guix.gnu.org as a content addressed mirror. 2023-02-11 20:34:22 +00:00
elf.scm
ftp-client.scm
gexp.scm gexp: computed-file: Do not honor %guile-for-build. 2023-02-27 15:54:09 +01:00
git-authenticate.scm
git-download.scm
git.scm git: Make better use of the better progress bar. 2023-02-19 01:00:06 +01:00
glob.scm
gnu-maintenance.scm gnu-maintenance: 'gnu' and 'gnu-ftp' predicates catch networking errors. 2023-01-08 16:11:45 +01:00
gnupg.scm
grafts.scm grafts: Run with a UTF-8 locale. 2022-11-11 23:17:42 +01:00
graph.js
graph.scm
hash.scm
hg-download.scm
http-client.scm
i18n.scm
inferior.scm inferior: Use 'spawn' on Guile 3.0.9+. 2023-01-26 11:11:18 +01:00
ipfs.scm
least-authority.scm
licenses.scm licenses: Update NPSL (nmap licence). 2023-02-12 01:00:00 +01:00
lint.scm Remove now unnecessary uses of (guix grafts). 2022-10-22 01:46:55 +02:00
man-db.scm
memoization.scm
modules.scm modules: Recognize #:declarative?. 2022-12-02 23:20:54 +01:00
monad-repl.scm
monads.scm
nar.scm
narinfo.scm narinfo: Fix misleading docstring. 2022-09-24 17:59:04 +02:00
openpgp.scm
packages.scm guix: packages: Add type hint comment to home-page record field. 2022-12-19 15:26:41 +04:00
pki.scm pki: 'public-keys->acl' deduplicates entries. 2022-12-12 15:03:05 +01:00
platform.scm platforms: Raise an exception when no suitable platform is found. 2023-01-18 20:53:15 -05:00
profiles.scm profiles: info-dir-file: Remove install-info '--silent' option. 2022-10-27 23:34:45 -04:00
profiling.scm
progress.scm guix: Show better progress bars. 2023-02-19 10:09:15 +01:00
quirks.scm
read-print.scm read-print: Do not use extended notation when printing '1+', '1-', etc. 2023-01-09 17:40:54 +01:00
records.scm records: match-record supports specifying a different variable name. 2022-12-27 23:53:42 +01:00
remote.scm
repl.scm
rpm.scm pack: Register extra /usr/share sub-directories as FHS. 2023-02-22 10:41:35 -05:00
scripts.scm ui: 'display-hint' quotes extra arguments for Texinfo. 2023-02-27 23:40:43 +01:00
search-paths.scm search-paths: Tweak $SSL_CERT_DIR comment. 2022-09-08 16:22:21 +02:00
self.scm self: Mark the generation (guix config) as non-declarative. 2022-11-14 12:31:33 +01:00
serialization.scm
sets.scm
ssh.scm ssh: Factor out progress % calculation. 2023-02-19 01:00:06 +01:00
status.scm ui: 'display-hint' quotes extra arguments for Texinfo. 2023-02-27 23:40:43 +01:00
store.scm grafts: Move '%graft?' and related bindings to (guix store). 2022-10-22 01:46:54 +02:00
substitutes.scm substitutes: Log the failing queries. 2023-01-07 14:27:17 +01:00
svn-download.scm svn-download: Add missing exports. 2022-10-17 23:15:08 +02:00
swh.scm
tests.scm
transformations.scm transformations: Let users know when '--with-latest' has no effect. 2023-01-16 13:41:27 +01:00
ui.scm ui: 'display-hint' quotes extra arguments for Texinfo. 2023-02-27 23:40:43 +01:00
upstream.scm upstream: Allow downgrades. 2023-01-03 12:25:48 +01:00
utils.scm utils: Add target-little-endian?. 2023-02-11 00:09:40 +01:00
workers.scm