mirror of
https://git.in.rschanz.org/ryan77627/guix.git
synced 2024-12-29 07:42:23 -05:00
bfe82fe2f6
Fixes <https://bugs.gnu.org/44261>. Reported by Jan Nieuwenhuizen <janneke@gnu.org>. * gnu/packages/aux-files/run-in-namespace.c (exec_in_user_namespace): Add call to 'prctl'. Call 'mount' for NEW_ROOT and define 'is_tmpfs'. When IS_TMPFS is true, call 'umount' and 'rmdir' after 'waitpid'; otherwise, call 'rm_rf' only when 'waitpid' returns -1 the second time. (exec_with_loader): Call 'prctl'. Remove NEW_ROOT only when 'waitpid' returns -1 the second time, otherwise leave it behind. * tests/guix-pack-relocatable.sh (wait_for_file): New function. Add test.
248 lines
9 KiB
Bash
248 lines
9 KiB
Bash
# GNU Guix --- Functional package management for GNU
|
|
# Copyright © 2018, 2019, 2020 Ludovic Courtès <ludo@gnu.org>
|
|
# Copyright © 2020 Eric Bavier <bavier@posteo.net>
|
|
#
|
|
# This file is part of GNU Guix.
|
|
#
|
|
# GNU Guix is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or (at
|
|
# your option) any later version.
|
|
#
|
|
# GNU Guix is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
#
|
|
# Test the 'guix pack --relocatable' using the external store, if any.
|
|
#
|
|
|
|
guix pack --version
|
|
|
|
# 'guix pack --relocatable' requires a C compiler and libc.a, which our
|
|
# bootstrap binaries don't provide. To make the test relatively inexpensive,
|
|
# run it on the user's global store if possible, on the grounds that binaries
|
|
# may already be there or can be built or downloaded inexpensively.
|
|
|
|
storedir="`guile -c '(use-modules (guix config))(display %storedir)'`"
|
|
localstatedir="`guile -c '(use-modules (guix config))(display %localstatedir)'`"
|
|
NIX_STORE_DIR="$storedir"
|
|
GUIX_DAEMON_SOCKET="$localstatedir/guix/daemon-socket/socket"
|
|
export NIX_STORE_DIR GUIX_DAEMON_SOCKET
|
|
|
|
if ! guile -c '(use-modules (guix)) (exit (false-if-exception (open-connection)))'
|
|
then
|
|
exit 77
|
|
fi
|
|
|
|
# Attempt to run the given command in a namespace where the store is
|
|
# invisible. This makes sure the presence of the store does not hide
|
|
# problems.
|
|
run_without_store ()
|
|
{
|
|
if unshare -r true # Are user namespaces supported?
|
|
then
|
|
# Run that relocatable executable in a user namespace where we "erase"
|
|
# the store by mounting an empty file system on top of it. That way,
|
|
# we exercise the wrapper code that creates the user namespace and
|
|
# bind-mounts the store.
|
|
unshare -mrf sh -c 'mount -t tmpfs -o ro none "$NIX_STORE_DIR"; '"$*"
|
|
else
|
|
# Run the relocatable program in the current namespaces. This is a
|
|
# weak test because we're going to access store items from the host
|
|
# store.
|
|
$*
|
|
fi
|
|
}
|
|
|
|
# Wait for the given file to show up. Error out if it doesn't show up in a
|
|
# timely fashion.
|
|
wait_for_file ()
|
|
{
|
|
i=0
|
|
while ! test -f "$1" && test $i -lt 20
|
|
do
|
|
sleep 0.3
|
|
i=`expr $i + 1`
|
|
done
|
|
test -f "$1"
|
|
}
|
|
|
|
test_directory="`mktemp -d`"
|
|
export test_directory
|
|
trap 'chmod -Rf +w "$test_directory"; rm -rf "$test_directory"' EXIT
|
|
|
|
if unshare -r true
|
|
then
|
|
# Test the 'userns' execution engine.
|
|
tarball="`guix pack -R -S /Bin=bin sed`"
|
|
(cd "$test_directory"; tar xvf "$tarball")
|
|
|
|
run_without_store "$test_directory/Bin/sed" --version > "$test_directory/output"
|
|
grep 'GNU sed' "$test_directory/output"
|
|
|
|
# Same with an explicit engine.
|
|
run_without_store GUIX_EXECUTION_ENGINE="userns" \
|
|
"$test_directory/Bin/sed" --version > "$test_directory/output"
|
|
grep 'GNU sed' "$test_directory/output"
|
|
|
|
# Check whether the exit code is preserved.
|
|
! run_without_store "$test_directory/Bin/sed" --does-not-exist
|
|
|
|
chmod -Rf +w "$test_directory"; rm -rf "$test_directory"/*
|
|
else
|
|
echo "'userns' execution tests skipped" >&2
|
|
fi
|
|
|
|
case "`uname -m`" in
|
|
x86_64|i?86)
|
|
# Try '-RR' and PRoot.
|
|
tarball="`guix pack -RR -S /Bin=bin sed`"
|
|
tar tvf "$tarball" | grep /bin/proot
|
|
(cd "$test_directory"; tar xf "$tarball")
|
|
run_without_store GUIX_EXECUTION_ENGINE="proot" \
|
|
"$test_directory/Bin/sed" --version > "$test_directory/output"
|
|
grep 'GNU sed' "$test_directory/output"
|
|
|
|
# Now with fakechroot.
|
|
run_without_store GUIX_EXECUTION_ENGINE="fakechroot" \
|
|
"$test_directory/Bin/sed" --version > "$test_directory/output"
|
|
grep 'GNU sed' "$test_directory/output"
|
|
unset GUIX_EXECUTION_ENGINE
|
|
|
|
chmod -Rf +w "$test_directory"; rm -rf "$test_directory"/*
|
|
|
|
if unshare -r true
|
|
then
|
|
# Check whether the store contains everything it should. Check
|
|
# once when erasing $STORE_PARENT ("/gnu") and once when erasing
|
|
# $NIX_STORE_DIR ("/gnu/store").
|
|
tarball="`guix pack -RR -S /bin=bin bash-minimal`"
|
|
(cd "$test_directory"; tar xf "$tarball")
|
|
|
|
STORE_PARENT="`dirname $NIX_STORE_DIR`"
|
|
export STORE_PARENT
|
|
|
|
for engine in userns proot fakechroot
|
|
do
|
|
for i in $(guix gc -R $(guix build bash-minimal | grep -v -e '-doc$'))
|
|
do
|
|
unshare -mrf sh -c "mount -t tmpfs none \"$NIX_STORE_DIR\"; GUIX_EXECUTION_ENGINE=$engine $test_directory/bin/sh -c 'echo $NIX_STORE_DIR/*'" | grep $(basename $i)
|
|
unshare -mrf sh -c "mount -t tmpfs none \"$STORE_PARENT\"; GUIX_EXECUTION_ENGINE=$engine $test_directory/bin/sh -c 'echo $NIX_STORE_DIR/*'" | grep $(basename $i)
|
|
done
|
|
done
|
|
|
|
chmod -Rf +w "$test_directory"; rm -rf "$test_directory"/*
|
|
fi
|
|
;;
|
|
*)
|
|
echo "skipping PRoot and Fakechroot tests" >&2
|
|
;;
|
|
esac
|
|
|
|
if unshare -r true
|
|
then
|
|
# Check what happens if the wrapped binary forks and leaves child
|
|
# processes behind, like a daemon. The root file system should remain
|
|
# available to those child processes. See <https://bugs.gnu.org/44261>.
|
|
cat > "$test_directory/manifest.scm" <<EOF
|
|
(use-modules (guix))
|
|
|
|
(define daemon
|
|
(program-file "daemon"
|
|
#~(begin
|
|
(use-modules (ice-9 match)
|
|
(ice-9 ftw))
|
|
|
|
(call-with-output-file "parent-store"
|
|
(lambda (port)
|
|
(write (scandir (ungexp (%store-prefix)))
|
|
port)))
|
|
|
|
(match (primitive-fork)
|
|
(0 (sigaction SIGHUP (const #t))
|
|
(call-with-output-file "pid"
|
|
(lambda (port)
|
|
(display (getpid) port)))
|
|
(pause)
|
|
(call-with-output-file "child-store"
|
|
(lambda (port)
|
|
(write (scandir (ungexp (%store-prefix)))
|
|
port))))
|
|
(_ #t)))))
|
|
|
|
(define package
|
|
(computed-file "package"
|
|
#~(let ((out (ungexp output)))
|
|
(mkdir out)
|
|
(mkdir (string-append out "/bin"))
|
|
(symlink (ungexp daemon)
|
|
(string-append out "/bin/daemon")))))
|
|
|
|
(manifest (list (manifest-entry
|
|
(name "daemon")
|
|
(version "0")
|
|
(item package))))
|
|
EOF
|
|
|
|
tarball="$(guix pack -S /bin=bin -R -m "$test_directory/manifest.scm")"
|
|
(cd "$test_directory"; tar xf "$tarball")
|
|
|
|
# Run '/bin/daemon', which forks, then wait for the child, send it SIGHUP
|
|
# so that it dumps its view of the store, and make sure the child and
|
|
# parent both see the same store contents.
|
|
(cd "$test_directory"; run_without_store ./bin/daemon)
|
|
wait_for_file "$test_directory/pid"
|
|
kill -HUP $(cat "$test_directory/pid")
|
|
wait_for_file "$test_directory/child-store"
|
|
diff -u "$test_directory/parent-store" "$test_directory/child-store"
|
|
|
|
chmod -Rf +w "$test_directory"; rm -rf "$test_directory"/*
|
|
fi
|
|
|
|
# Ensure '-R' works with outputs other than "out".
|
|
tarball="`guix pack -R -S /share=share groff:doc`"
|
|
(cd "$test_directory"; tar xf "$tarball")
|
|
test -d "$test_directory/share/doc/groff/html"
|
|
chmod -Rf +w "$test_directory"; rm -rf "$test_directory"/*
|
|
|
|
# Ensure '-R' applies to propagated inputs. Failing to do that, it would fail
|
|
# with a profile collision error in this case because 'python-scipy'
|
|
# propagates 'python-numpy'. See <https://bugs.gnu.org/42510>.
|
|
guix pack -RR python-numpy python-scipy --no-grafts -n
|
|
|
|
# Check that packages that mix executable and support files (e.g. git) in the
|
|
# "binary" directories still work after wrapped.
|
|
cat >"$test_directory/manifest.scm" <<'EOF'
|
|
(use-modules (guix) (guix profiles) (guix search-paths)
|
|
(gnu packages bootstrap))
|
|
(manifest
|
|
(list (manifest-entry
|
|
(name "test") (version "0")
|
|
(item (file-union "test"
|
|
`(("bin/hello"
|
|
,(program-file
|
|
"hello"
|
|
#~(begin
|
|
(add-to-load-path (getenv "HELLO_EXEC_PATH"))
|
|
(display (load-from-path "msg"))(newline))
|
|
#:guile %bootstrap-guile))
|
|
("libexec/hello/msg"
|
|
,(plain-file "msg" "42")))))
|
|
(search-paths
|
|
(list (search-path-specification
|
|
(variable "HELLO_EXEC_PATH")
|
|
(files '("libexec/hello"))
|
|
(separator #f)))))))
|
|
EOF
|
|
tarball="`guix pack -RR -S /opt= -m $test_directory/manifest.scm`"
|
|
(cd "$test_directory"; tar xvf "$tarball")
|
|
( export GUIX_PROFILE=$test_directory/opt
|
|
. $GUIX_PROFILE/etc/profile
|
|
run_without_store "$test_directory/opt/bin/hello" > "$test_directory/output" )
|
|
cat "$test_directory/output"
|
|
test "`cat $test_directory/output`" = "42"
|