Ludovic Courtès 8f4ffb3fae daemon: Protect against FD escape when building fixed-output derivations (CVE-2024-27297). ... This fixes a security issue (CVE-2024-27297) whereby a fixed-output derivation build process could open a writable file descriptor to its output, send it to some outside process for instance over an abstract AF_UNIX socket, which would then allow said process to modify the file in the store after it has been marked as “valid”. Vulnerability discovered by puck <https://github.com/puckipedia>. Nix security advisory: https://github.com/NixOS/nix/security/advisories/GHSA-2ffj-w4mj-pg37 Nix fix: 244f3eee0b * nix/libutil/util.cc (readDirectory): Add variants that take a DIR* and a file descriptor. Rewrite the ‘Path’ variant accordingly. (copyFile, copyFileRecursively): New functions. * nix/libutil/util.hh (copyFileRecursively): New declaration. * nix/libstore/build.cc (DerivationGoal::buildDone): When ‘fixedOutput’ is true, call ‘copyFileRecursively’ followed by ‘rename’ on each output. Change-Id: I7952d41093eed26e123e38c14a4c1424be1ce1c4 Reported-by: Picnoir <picnoir@alternativebit.fr>, Théophane Hufschmitt <theophane.hufschmitt@tweag.io> Change-Id: Idb5f2757f35af86b032a9851cecb19b70227bd88		2024-03-11 22:12:34 +01:00
..
.gitignore
build.cc	daemon: Protect against FD escape when building fixed-output derivations (CVE-2024-27297).	2024-03-11 22:12:34 +01:00
builtins.cc
builtins.hh
derivations.cc
derivations.hh
gc.cc
globals.cc	daemon: Change default ‘timeout’ and ‘max-silent-time’ values.	2024-01-05 17:27:21 +01:00
globals.hh
local-store.cc
local-store.hh
misc.cc
misc.hh
optimise-store.cc
pathlocks.cc
pathlocks.hh
references.cc
references.hh
sqlite.cc
sqlite.hh
store-api.cc
store-api.hh
worker-protocol.hh	daemon: Implement ‘substitute-urls’ RPC.	2023-12-11 23:18:53 +01:00