mirror of
https://git.in.rschanz.org/ryan77627/guix.git
synced 2024-12-26 06:18:07 -05:00
fb7e6ccba7
Previously field type errors would be reported in a non-standard way, and without any source location information. This fixes it. * gnu/services/configuration.scm (configuration-field-error): Add a 'loc' parameter and honor it. Use 'formatted-message' instead of plain 'format'. (define-configuration-helper)[field-sanitizer]: New procedure. Use it. Use STEM as the identifier of the syntactic constructor of the record type. Add a 'sanitize' property to each field. Remove now useless STEM macro that would call 'validate-configuration'. * gnu/services/mail.scm (serialize-listener-configuration): Adjust to new 'configuration-field-error' prototype. * tests/services/configuration.scm ("wrong type for a field"): New test. * po/guix/POTFILES.in: Add gnu/services/configuration.scm.
163 lines
5.1 KiB
Scheme
163 lines
5.1 KiB
Scheme
;;; GNU Guix --- Functional package management for GNU
|
||
;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer@gmail.com>
|
||
;;; Copyright © 2021 Xinglu Chen <public@yoctocell.xyz>
|
||
;;; Copyright © 2022 Ludovic Courtès <ludo@gnu.org>
|
||
;;;
|
||
;;; This file is part of GNU Guix.
|
||
;;;
|
||
;;; GNU Guix is free software; you can redistribute it and/or modify it
|
||
;;; under the terms of the GNU General Public License as published by
|
||
;;; the Free Software Foundation; either version 3 of the License, or (at
|
||
;;; your option) any later version.
|
||
;;;
|
||
;;; GNU Guix is distributed in the hope that it will be useful, but
|
||
;;; WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
;;; GNU General Public License for more details.
|
||
;;;
|
||
;;; You should have received a copy of the GNU General Public License
|
||
;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
|
||
|
||
(define-module (tests services configuration)
|
||
#:use-module (gnu services configuration)
|
||
#:use-module (guix diagnostics)
|
||
#:use-module (guix gexp)
|
||
#:use-module (srfi srfi-34)
|
||
#:use-module (srfi srfi-64))
|
||
|
||
;;; Tests for the (gnu services configuration) module.
|
||
|
||
(test-begin "services-configuration")
|
||
|
||
(define (serialize-number field value)
|
||
(format #f "~a=~a" field value))
|
||
|
||
|
||
;;;
|
||
;;; define-configuration macro.
|
||
;;;
|
||
|
||
(define-configuration port-configuration
|
||
(port (number 80) "The port number.")
|
||
(no-serialization))
|
||
|
||
(test-equal "default value, no serialization"
|
||
80
|
||
(port-configuration-port (port-configuration)))
|
||
|
||
(test-equal "wrong type for a field"
|
||
'("configuration.scm" 57 11) ;error location
|
||
(guard (c ((configuration-error? c)
|
||
(let ((loc (error-location c)))
|
||
(list (basename (location-file loc))
|
||
(location-line loc)
|
||
(location-column loc)))))
|
||
(port-configuration
|
||
;; This is line 56; the test relies on line/column numbers!
|
||
(port "This is not a number!"))))
|
||
|
||
(define-configuration port-configuration-cs
|
||
(port (number 80) "The port number." empty-serializer))
|
||
|
||
(test-equal "default value, custom serializer"
|
||
80
|
||
(port-configuration-cs-port (port-configuration-cs)))
|
||
|
||
(define-configuration port-configuration-ndv
|
||
(port (number) "The port number."))
|
||
|
||
(test-equal "no default value, provided"
|
||
55
|
||
(port-configuration-ndv-port (port-configuration-ndv
|
||
(port 55))))
|
||
|
||
(test-assert "no default value, not provided"
|
||
(guard (c ((configuration-error? c)
|
||
#t))
|
||
(port-configuration-ndv-port (port-configuration-ndv))))
|
||
|
||
(define (custom-number-serializer name value)
|
||
(format #f "~a = ~a;" name value))
|
||
|
||
(define-configuration serializable-configuration
|
||
(port (number 80) "The port number." custom-number-serializer))
|
||
|
||
(test-assert "serialize-configuration"
|
||
(gexp?
|
||
(let ((config (serializable-configuration)))
|
||
(serialize-configuration config serializable-configuration-fields))))
|
||
|
||
(define-configuration serializable-configuration
|
||
(port (number 80) "The port number." custom-number-serializer)
|
||
(no-serialization))
|
||
|
||
(test-assert "serialize-configuration with no-serialization"
|
||
;; When serialization is disabled, the serializer is set to #f, so
|
||
;; attempting to use it fails with a 'wrong-type-arg' error.
|
||
(not (false-if-exception
|
||
(let ((config (serializable-configuration)))
|
||
(serialize-configuration config serializable-configuration-fields)))))
|
||
|
||
(define (custom-prefix-serialize-integer field-name name) name)
|
||
|
||
(define-configuration configuration-with-prefix
|
||
(port (integer 10) "The port number.")
|
||
(prefix custom-prefix-))
|
||
|
||
(test-assert "serialize-configuration with prefix"
|
||
(gexp?
|
||
(let ((config (configuration-with-prefix)))
|
||
(serialize-configuration config configuration-with-prefix-fields))))
|
||
|
||
|
||
;;;
|
||
;;; define-maybe macro.
|
||
;;;
|
||
(define-maybe number)
|
||
|
||
(define-configuration config-with-maybe-number
|
||
(port (maybe-number 80) "")
|
||
(count maybe-number ""))
|
||
|
||
(test-equal "maybe value serialization"
|
||
"port=80"
|
||
(serialize-maybe-number "port" 80))
|
||
|
||
(define (config-with-maybe-number->string x)
|
||
(eval (gexp->approximate-sexp
|
||
(serialize-configuration x config-with-maybe-number-fields))
|
||
(current-module)))
|
||
|
||
(test-equal "maybe value serialization of the instance"
|
||
"port=42count=43"
|
||
(config-with-maybe-number->string
|
||
(config-with-maybe-number
|
||
(port 42)
|
||
(count 43))))
|
||
|
||
(test-equal "maybe value serialization of the instance, unspecified"
|
||
"port=42"
|
||
(config-with-maybe-number->string
|
||
(config-with-maybe-number
|
||
(port 42))))
|
||
|
||
(define-maybe/no-serialization string)
|
||
|
||
(define-configuration config-with-maybe-string/no-serialization
|
||
(name (maybe-string) "The name of the item.")
|
||
(no-serialization))
|
||
|
||
(test-assert "maybe value without serialization no procedure bound"
|
||
(not (defined? 'serialize-maybe-string)))
|
||
|
||
(test-assert "maybe type, no default"
|
||
(unspecified?
|
||
(config-with-maybe-string/no-serialization-name
|
||
(config-with-maybe-string/no-serialization))))
|
||
|
||
(test-assert "maybe type, with default"
|
||
(equal?
|
||
"foo"
|
||
(config-with-maybe-string/no-serialization-name
|
||
(config-with-maybe-string/no-serialization
|
||
(name "foo")))))
|