mirror of
https://git.in.rschanz.org/ryan77627/guix.git
synced 2024-11-07 15:36:20 -05:00
50fc2384fe
Rather than emiting warnings directly to a port, have the checkers return the
warning or warnings.
This makes it easier to use the warnings in different ways, for example,
loading the data in to a database, as you can work with the <lint-warning>
records directly, rather than having to parse the output to determine the
package and location.
* guix/scripts/lint.scm (<lint-warning>): New record type.
(lint-warning): New macro.
(lint-warning?, lint-warning-package, lint-warning-message,
lint-warning-location, package-file, make-warning): New procedures.
(call-with-accumulated-warnings, with-accumulated-warnings): Remove.
(emit-warning): Rename to emit-warnings, and switch to displaying multiple
warnings.
(check-description-style)[check-not-empty-description, check-texinfo-markup,
check-trademarks, check-quotes, check-proper-start,
check-end-of-sentence-space]: Switch to generating a list of warnings, and
using make-warning, rather than emit-warning.
(check-inputs-should-be-native, check-inputs-should-not-be-an-input-at-all):
Switch to generating a list of warnings, and using make-warning, rather than
emit-warning.
(check-synopsis): Switch to generating a list of warnings, and using
make-warning, rather than emit-warning.
[check-not-empty]: Remove, this is handled in the match clause
to avoid other warnings being emitted.
[check-final-period, check-start-article, check-synopsis-length,
check-proper-start, check-start-with-package-name, check-texinfo-markup]:
Switch to generating a list of warnings, and using make-warning, rather than
emit-warning.
[checks]: Remove check-not-empty.
(validate-uri, check-home-page, check-patch-file-names,
check-gnu-synopsis+description): Switch to generating a list of warnings, and
using make-warning, rather than emit-warning.
(check-source): Switch to generating a list of warnings, and using
make-warning, rather than emit-warning.
[try-uris]: Remove.
[warnings-for-uris]: New procedure, replacing try-uris.
(check-source-file-name, check-source-unstable-tarball, check-mirror-url,
check-github-url, check-derivation, check-vulnerabilities, check-for-updates,
report-tabulations, report-trailing-white-space, report-long-line,
report-lone-parentheses, report-formatting-issues, check-formatting): Switch
to generating a list of warnings, and using make-warning, rather than
emit-warning.
(run-checkers): Call emit-warnings on the warnings returned from the checker.
* tests/lint.scm (string-match-or-error, single-lint-warning-message): New
procedures.
(call-with-warnings, with-warnings): Remove.
("description: not a string", "description: not empty", "description: invalid
Texinfo markup", "description: does not start with an upper-case letter",
"description: may start with a digit", "description: may start with lower-case
package name", "description: two spaces after end of sentence", "description:
end-of-sentence detection with abbreviations", "description: may not contain
trademark signs: ™", "description: may not contain trademark signs: ®",
"description: suggest ornament instead of quotes", "synopsis: not a string",
"synopsis: not empty", "synopsis: valid Texinfo markup", "synopsis: does not
start with an upper-case letter", "synopsis: may start with a digit",
"synopsis: ends with a period", "synopsis: ends with 'etc.'", "synopsis:
starts with 'A'", "synopsis: starts with 'a'", "synopsis: starts with 'an'",
"synopsis: too long", "synopsis: start with package name", "synopsis: start
with package name prefix", "synopsis: start with abbreviation", "inputs:
pkg-config is probably a native input", "inputs: glib:bin is probably a native
input", "inputs: python-setuptools should not be an input at all (input)",
"inputs: python-setuptools should not be an input at all (native-input)",
"inputs: python-setuptools should not be an input at all (propagated-input)",
"patches: file names", "patches: file name too long", "patches: not found",
"derivation: invalid arguments", "license: invalid license", "home-page: wrong
home-page", "home-page: invalid URI", "home-page: host not found", "home-page:
Connection refused", "home-page: 200", "home-page: 200 but short length",
"home-page: 404", "home-page: 301, invalid", "home-page: 301 -> 200",
"home-page: 301 -> 404", "source-file-name", "source-file-name: v prefix",
"source-file-name: bad checkout", "source-file-name: good checkout",
"source-file-name: valid", "source-unstable-tarball",
"source-unstable-tarball: source #f", "source-unstable-tarball: valid",
"source-unstable-tarball: package named archive", "source-unstable-tarball:
not-github", "source-unstable-tarball: git-fetch", "source: 200", "source: 200
but short length", "source: 404", "source: 301 -> 200", "source: 301 -> 404",
"mirror-url", "mirror-url: one suggestion", "github-url", "github-url: one
suggestion", "github-url: already the correct github url", "cve", "cve: one
vulnerability", "cve: one patched vulnerability", "cve: known safe from
vulnerability", "cve: vulnerability fixed in replacement version", "cve:
patched vulnerability in replacement", "formatting: lonely parentheses",
"formatting: alright"): Change test-assert to test-equal, and adjust to work
with the changes above.
("formatting: tabulation", "formatting: trailing white space", "formatting:
long line"): Use string-match-or-error rather than string-contains.
|
||
|---|---|---|
| .. | ||
| accounts.scm | ||
| base16.scm | ||
| base32.scm | ||
| base64.scm | ||
| bournish.scm | ||
| build-utils.scm | ||
| builders.scm | ||
| cache.scm | ||
| challenge.scm | ||
| channels.scm | ||
| combinators.scm | ||
| containers.scm | ||
| cpan.scm | ||
| cpio.scm | ||
| cran.scm | ||
| crate.scm | ||
| cve-sample.xml | ||
| cve.scm | ||
| debug-link.scm | ||
| derivations.scm | ||
| discovery.scm | ||
| elpa.scm | ||
| file-systems.scm | ||
| gem.scm | ||
| gexp.scm | ||
| glob.scm | ||
| gnu-maintenance.scm | ||
| grafts.scm | ||
| graph.scm | ||
| gremlin.scm | ||
| guix-archive.sh | ||
| guix-authenticate.sh | ||
| guix-build-branch.sh | ||
| guix-build.sh | ||
| guix-daemon.sh | ||
| guix-describe.sh | ||
| guix-download.sh | ||
| guix-environment-container.sh | ||
| guix-environment.sh | ||
| guix-gc.sh | ||
| guix-graph.sh | ||
| guix-hash.sh | ||
| guix-lint.sh | ||
| guix-pack-localstatedir.sh | ||
| guix-pack-relocatable.sh | ||
| guix-pack.sh | ||
| guix-package-aliases.sh | ||
| guix-package-net.sh | ||
| guix-package.sh | ||
| guix-system.sh | ||
| hackage.scm | ||
| import-utils.scm | ||
| inferior.scm | ||
| lint.scm | ||
| lzlib.scm | ||
| modules.scm | ||
| monads.scm | ||
| nar.scm | ||
| opam.scm | ||
| pack.scm | ||
| packages.scm | ||
| pki.scm | ||
| print.scm | ||
| processes.scm | ||
| profiles.scm | ||
| publish.scm | ||
| pypi.scm | ||
| records.scm | ||
| scripts-build.scm | ||
| scripts.scm | ||
| search-paths.scm | ||
| services.scm | ||
| sets.scm | ||
| signing-key.pub | ||
| signing-key.sec | ||
| size.scm | ||
| snix.scm | ||
| status.scm | ||
| store-database.scm | ||
| store-deduplication.scm | ||
| store-roots.scm | ||
| store.scm | ||
| substitute.scm | ||
| syscalls.scm | ||
| system.scm | ||
| test.drv | ||
| texlive.scm | ||
| ui.scm | ||
| union.scm | ||
| upstream.scm | ||
| utils.scm | ||
| uuid.scm | ||
| workers.scm | ||
| zlib.scm | ||